Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] TPU + all_gather + SingleTPU shouldn't call xm.all_gather #6296

Merged
merged 6 commits into from
Mar 3, 2021
Merged

[bugfix] TPU + all_gather + SingleTPU shouldn't call xm.all_gather #6296

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f86cb23
resolve an issue with TPU
tchaton Mar 2, 2021
1c11a91
update
tchaton Mar 2, 2021
918d784
add changelog
tchaton Mar 2, 2021
659900d
typo
tchaton Mar 2, 2021
fae08de
Update CHANGELOG.md
tchaton Mar 2, 2021
15d5fd8
Merge branch 'master' into bugfix_5181
tchaton Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed duplicate logs appearing in console when using the python logging module ([#5509](https://github.com/PyTorchLightning/pytorch-lightning/pull/5509), [#6275](https://github.com/PyTorchLightning/pytorch-lightning/pull/6275))


- Fixed `all_gather` on SingleTPU shouldn't call `all_gather` ([#6296](https://github.com/PyTorchLightning/pytorch-lightning/pull/6296))
tchaton marked this conversation as resolved.
Show resolved Hide resolved


## [1.2.1] - 2021-02-23

### Fixed
Expand Down
5 changes: 4 additions & 1 deletion pytorch_lightning/accelerators/tpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,7 @@ def all_gather(self, tensor: torch.Tensor, group: Optional[Any] = None, sync_gra
Return:
A tensor of shape (world_size, batch, ...)
"""
return xm.all_gather(tensor, group=group, sync_grads=sync_grads)
# todo: Add support for backward with all_gather
if torch.distributed.is_initialized():
return xm.all_gather(tensor, group=group, sync_grads=sync_grads)
return tensor
Comment on lines +49 to +52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cov complaining about no test, probably want to add one to make sure this case is covered in single TPU!

Copy link
Contributor Author

@tchaton tchaton Mar 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test updates cover this part but coverage is currently not supported for TPU.