Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 23, 2021

What does this PR do?

Fixing breaking API introduced in #6506

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 1 Medium priority task labels Mar 23, 2021
@Borda Borda added this to the 1.3 milestone Mar 23, 2021
@Borda Borda requested a review from SeanNaren March 23, 2021 16:14
@Borda Borda enabled auto-merge (squash) March 23, 2021 16:14
@Borda Borda requested review from a team, ananthsub, carmocca, rohitgr7 and s-rog March 23, 2021 16:15
@Borda Borda added the ready PRs ready to be merged label Mar 23, 2021
@Borda Borda merged commit 3cf0c31 into master Mar 23, 2021
@Borda Borda deleted the fix/6506 branch March 23, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants