Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Patch Release v.1.2.8 [full merge, no squash] #6983

Merged
merged 22 commits into from
Apr 14, 2021
Merged

Commits on Apr 13, 2021

  1. Fix EarlyStopping logic when min_epochs not met (#6705)

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    
    (cherry picked from commit 127c52a)
    awaelchli authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    4ab5579 View commit details
    Browse the repository at this point in the history
  2. CI: fixture for global rank variable reset (#6839)

    (cherry picked from commit b7a22ba)
    awaelchli authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    bc25c23 View commit details
    Browse the repository at this point in the history
  3. [fix] Better support for rank_zero_only setting for SLURM and torchel…

    …astic (#6802)
    
    Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    (cherry picked from commit 86e1d9f)
    ananthsub authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    77fbfd9 View commit details
    Browse the repository at this point in the history
  4. Fix csv extension check (#6436)

    Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
    (cherry picked from commit 01b9cf8)
    5n7-sk authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    9799cfd View commit details
    Browse the repository at this point in the history
  5. Remove hardcoding of rank_zero_only.rank in accelerator connector (#6878

    )
    
    (cherry picked from commit 968ac09)
    ananthsub authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    593ae70 View commit details
    Browse the repository at this point in the history
  6. Fix finetuning complex models correctly unfreezes. (#6880)

    Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
    
    (cherry picked from commit eb15abc)
    scart97 authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    9b6374f View commit details
    Browse the repository at this point in the history
  7. Fix DDP_SPAWN compatibility with bug_report_model.py (#6892)

    (cherry picked from commit 87f0aea)
    ethanwharris authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    1769e28 View commit details
    Browse the repository at this point in the history
  8. TPUSpawn + IterableDataset error message (#6875)

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    
    (cherry picked from commit 1c2ecbf)
    ethanwharris authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    6f7cf59 View commit details
    Browse the repository at this point in the history
  9. [Fix] Ensure we set the eval/train flag correctly on accelerator model (

    #6877)
    
    * Ensure we move the model to eval mode before running evaluation
    
    * Ensure we set the flag appropriately across all stages
    
    * Add test, move hooks logic
    
    * Apply same fix to the validate loop
    
    * Update pytorch_lightning/trainer/trainer.py
    
    * Fix function name
    
    * Fix order, add predict
    
    * Shorten the name
    
    * Fix input dm, drop duplicate on predict start hook call, as it's called in the setup function
    
    * Use hook, remove double call
    
    (cherry picked from commit 742c48e)
    Sean Naren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    78a6ad5 View commit details
    Browse the repository at this point in the history
  10. fix exception raising (#6901)

    (cherry picked from commit 90e37ba)
    kandluis authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    94eaef6 View commit details
    Browse the repository at this point in the history
  11. fix gpus default for Trainer.add_argparse_args (#6898)

    (cherry picked from commit 9c9e2a0)
    awaelchli authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    f895e9f View commit details
    Browse the repository at this point in the history
  12. Fix TPU Spawn gather (#6896)

    (cherry picked from commit 5552503)
    kaushikb11 authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    8245540 View commit details
    Browse the repository at this point in the history
  13. Fix ShardedDataParallel has no attribute require_backward_grad_sync (#…

    …6915)
    
    Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
    (cherry picked from commit fe0d088)
    awaelchli authored and SeanNaren committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    d78d232 View commit details
    Browse the repository at this point in the history
  14. Brew update to fix mac tests (#6970)

    * Drop libomp to see what happens
    
    * Drop openmpi/horovod installs
    
    * Revert "Drop libomp to see what happens"
    
    This reverts commit cdd524f
    
    * Update before install
    
    * Skip horovod failing test
    
    (cherry picked from commit e9c3e02)
    Sean Naren authored and awaelchli committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    5d347e9 View commit details
    Browse the repository at this point in the history
  15. [CI] Drop brew update (#6985)

    (cherry picked from commit 23e8dff)
    Sean Naren authored and awaelchli committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    8028386 View commit details
    Browse the repository at this point in the history
  16. Fix Checkpoint issue when using Horovod distributed backend (PyTorchL…

    …ightning#6947) (#6958)
    
    Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com>
    
    Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    
    (cherry picked from commit b37b58a)
    liob authored and awaelchli committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    25b4075 View commit details
    Browse the repository at this point in the history
  17. update docker base on PT 1.7 (#6931)

    * update docker base on PT 1.7
    
    * fix path
    
    (cherry picked from commit da1ac3a)
    Borda authored and awaelchli committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    c348bfc View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Add imports

    SeanNaren authored and Borda committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    3e77551 View commit details
    Browse the repository at this point in the history
  2. Fix sync_dist for tpus (#6950)

    (cherry picked from commit 1b3e4f9)
    kaushikb11 authored and Borda committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    782145e View commit details
    Browse the repository at this point in the history
  3. remove outdated test (removed on master)

    awaelchli authored and Borda committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    45b36c1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8f7f56 View commit details
    Browse the repository at this point in the history
  5. v1.2.8 & Update CHANGELOG.md

    SeanNaren authored and Borda committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6be2b03 View commit details
    Browse the repository at this point in the history