Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better approach to register plugins #7063

Merged
merged 7 commits into from
Apr 18, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Apr 16, 2021

What does this PR do?

Better approach to register plugins

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually would we enable plugins outside this repo to add to this registry?

pytorch_lightning/plugins/plugins_registry.py Outdated Show resolved Hide resolved
@kaushikb11 kaushikb11 changed the title Better approach to register plugins Better approach to register plugins & ddp_with_find_unused_parameters_false Apr 16, 2021
@kaushikb11 kaushikb11 added this to the 1.3 milestone Apr 16, 2021
@kaushikb11 kaushikb11 changed the title Better approach to register plugins & ddp_with_find_unused_parameters_false Better approach to register plugins & add ddp_with_find_unused_parameters_false Apr 16, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but as ananth said, let's save the other config for a separate PR!

I have a few concerns of the name we gave ddp with find_unused_params=false since its quite long and I'd like the alias to be as small as possible :)

Eventually would we enable plugins outside this repo to add to this registry?

How would you envision this? I think other repos can add to the registry as normal, however these would be localized to the users' repository

@kaushikb11 kaushikb11 changed the title Better approach to register plugins & add ddp_with_find_unused_parameters_false Better approach to register plugins Apr 16, 2021
@kaushikb11
Copy link
Contributor Author

I have a few concerns of the name we gave ddp with find_unused_params=false since its quite long and I'd like the alias to be as small as possible :)

Haha, @SeanNaren. I wasn't the biggest fan of the name either lol. Suggestions are welcome :))

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@3fb8ead). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #7063   +/-   ##
========================================
  Coverage          ?     87%           
========================================
  Files             ?     196           
  Lines             ?   12616           
  Branches          ?       0           
========================================
  Hits              ?   10968           
  Misses            ?    1648           
  Partials          ?       0           

@kaushikb11 kaushikb11 self-assigned this Apr 18, 2021
@kaushikb11 kaushikb11 added the ready PRs ready to be merged label Apr 18, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda Borda merged commit 97be843 into Lightning-AI:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants