[feat] Add better support for predict + ddp 2/3 #7215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
reviewed
Apr 26, 2021
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
ananthsub
approved these changes
Apr 26, 2021
kaushikb11
reviewed
Apr 26, 2021
Borda
reviewed
Apr 26, 2021
edgarriba
reviewed
Apr 26, 2021
awaelchli
reviewed
Apr 27, 2021
Comment on lines
50
to
52
| @property | ||
| def use_spawn(self) -> bool: | ||
| return False |
There was a problem hiding this comment.
I would avoid this. Can we do isinstance check?
There was a problem hiding this comment.
Yes, but I find it less clean.
There was a problem hiding this comment.
The problem is this style of adding properties that identify each plugin will not scale long term and at the finest granularity it is the same as an instance check.
it could be part of the accelerator connector refactor one day. The use_spawn could be handled by the connector.
carmocca
approved these changes
Apr 27, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
SeanNaren
reviewed
Apr 27, 2021
| @@ -75,3 +76,70 @@ def prepare_for_backward(model: DistributedDataParallel, output: Any): | |||
| model.reducer.prepare_for_backward([]) | |||
| else: | |||
| model.require_forward_param_sync = False | |||
|
|
|||
|
|
|||
| class UnrepeatedDistributedSampler(DistributedSampler): | |||
There was a problem hiding this comment.
Is NoPaddingDistributedSampler clearer?
Any comment here? @tchaton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Here is PR 1/2: #7141
This PR adds better support for predict.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃