Issue #657 - Call on_train_end after early stopping

[HarshSharma12]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
• Did you read the contributor guideline?
• Did you make sure to update the docs?
• Did you write any new necessary tests?

What does this PR do?

Fixes Issue 657

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[neggert]

Thanks for tackling this! This solution works, but I think a better solution would be to change the early return into a break. Then all the same code gets called regardless of whether the loop ended or we stopped early. Should be easier to maintain in the long run.

Could you also please add a test so we can make sure this problem doesn't pop up again in the future?

[williamFalcon]

@HarshSharma12 rebase master please? it fixes GPU tests

[HarshSharma12]

there were tests that already covered this but I updated them a little. created a new PR with the changes and test updates