Reset current_fx properties on lightning module in teardown #7247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
|
Hello @ananthsub! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-28 18:27:27 UTC |
Codecov Report
@@ Coverage Diff @@
## master #7247 +/- ##
=======================================
- Coverage 91% 85% -6%
=======================================
Files 199 199
Lines 12783 13342 +559
=======================================
- Hits 11662 11331 -331
- Misses 1121 2011 +890 |
ananthsub
commented
Apr 28, 2021
tests/trainer/test_trainer.py
Outdated
Comment on lines
2065
to
2071
| assert model._current_fx_name == "", f"_current_fx_name not reset after fit: {model._current_fx_name}" | ||
| assert model._current_hook_fx_name is None, f"_current_hook_fx_name not reset after fit: {model._current_hook_fx_name}" | ||
| assert model._current_dataloader_idx is None, f"_current_dataloader_idx not reset after fit: {model._current_dataloader_idx}" | ||
| trainer.test(model) | ||
| assert model._current_fx_name == "", f"_current_fx_name not reset after test: {model._current_fx_name}" | ||
| assert model._current_hook_fx_name is None, f"_current_hook_fx_name not reset after test: {model._current_hook_fx_name}" | ||
| assert model._current_dataloader_idx is None, f"_current_dataloader_idx not reset after test: {model._current_dataloader_idx}" |
There was a problem hiding this comment.
@Borda I ran yapf and pre-commit on this file but it looks like they didn't take effect based on the failing test
There was a problem hiding this comment.
In these cases where yapf fails or produces bad output, I usually run black -S -l120 and then yapf to fix it.
The output was: dd6cf9d
justusschock
approved these changes
Apr 28, 2021
carmocca
reviewed
Apr 28, 2021
tests/trainer/test_trainer.py
Outdated
Comment on lines
2065
to
2071
| assert model._current_fx_name == "", f"_current_fx_name not reset after fit: {model._current_fx_name}" | ||
| assert model._current_hook_fx_name is None, f"_current_hook_fx_name not reset after fit: {model._current_hook_fx_name}" | ||
| assert model._current_dataloader_idx is None, f"_current_dataloader_idx not reset after fit: {model._current_dataloader_idx}" | ||
| trainer.test(model) | ||
| assert model._current_fx_name == "", f"_current_fx_name not reset after test: {model._current_fx_name}" | ||
| assert model._current_hook_fx_name is None, f"_current_hook_fx_name not reset after test: {model._current_hook_fx_name}" | ||
| assert model._current_dataloader_idx is None, f"_current_dataloader_idx not reset after test: {model._current_dataloader_idx}" |
There was a problem hiding this comment.
In these cases where yapf fails or produces bad output, I usually run black -S -l120 and then yapf to fix it.
The output was: dd6cf9d
carmocca
reviewed
Apr 28, 2021
carmocca
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This isn't an issue with master, but it's extra precaution that these fields are reset before control returns back to the caller
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃