Restore trainer.current_epoch after tuning
#7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
added
bug
Codecov Report
@@ Coverage Diff @@
## master #7434 +/- ##
======================================
- Coverage 92% 92% -0%
======================================
Files 200 199 -1
Lines 12992 12988 -4
======================================
- Hits 11918 11910 -8
- Misses 1074 1078 +4 |
akihironitta
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
SkafteNicki,
tchaton and
williamFalcon
as code owners
SkafteNicki
approved these changes
May 7, 2021
awaelchli
approved these changes
May 7, 2021
tests/tuner/test_lr_finder.py
Outdated
Comment on lines
80
to
86
| 'callbacks', | ||
| 'logger', | ||
| 'max_steps', | ||
| 'auto_lr_find', | ||
| 'accumulate_grad_batches', | ||
| 'checkpoint_callback', | ||
| 'current_epoch', |
There was a problem hiding this comment.
one could consider alphabetical ordering 😃
There was a problem hiding this comment.
n00b question: how do we know this is the exhaustive list?
ananthsub
approved these changes
May 7, 2021
Borda
approved these changes
May 8, 2021
Closed
Borda
pushed a commit
that referenced
this pull request
May 11, 2021
* Add a test * Save and restore current_epoch * Update CHANGELOG * alphabetical order (cherry picked from commit 710b144)
Borda
pushed a commit
that referenced
this pull request
May 11, 2021
* Add a test * Save and restore current_epoch * Update CHANGELOG * alphabetical order (cherry picked from commit 710b144)
Borda
pushed a commit
that referenced
this pull request
May 11, 2021
* Add a test * Save and restore current_epoch * Update CHANGELOG * alphabetical order (cherry picked from commit 710b144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5587.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list: