Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 14, 2021

What does this PR do?

discussed @yukw777 moving as Alumni but happy to welcome him back as core when he feels so :]

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label May 14, 2021
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #7545 (d77372e) into master (a584196) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7545   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         196     196           
  Lines       12828   12835    +7     
======================================
- Hits        11825   11816    -9     
- Misses       1003    1019   +16     

@Borda Borda requested review from a team and yukw777 May 14, 2021 12:25
Leads
-----
- William Falcon (`williamFalcon <https://github.com/williamFalcon>`_) (Lightning founder)
- Jirka Borovec (`Borda <https://github.com/Borda>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good thing, right? 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you never know :D

@awaelchli awaelchli added this to the v1.4 milestone May 14, 2021
@awaelchli awaelchli merged commit 53f8d9a into master May 14, 2021
@awaelchli awaelchli deleted the docs/alumni branch May 14, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants