Remove tests dir from distribution

[flying-sheep]

You’re using find_packages wrong. It expects package paths (with .) not file paths.

Docs: https://setuptools.readthedocs.io/en/latest/userguide/package_discovery.html#using-find-or-find-packages

[codecov]

Codecov Report

Merging #7596 (3e73d9d) into master (b214442) will decrease coverage by 3%.
The diff coverage is n/a.

❗ Current head 3e73d9d differs from pull request most recent head c5fb60e. Consider uploading reports for the commit c5fb60e to get more accurate results

@@           Coverage Diff           @@
##           master   #7596    +/-   ##
=======================================
- Coverage      91%     88%    -3%     
=======================================
  Files         204     199     -5     
  Lines       13630   13017   -613     
=======================================
- Hits        12414   11432   -982     
- Misses       1216    1585   +369     

[ethanwharris]

LGTM 😃

[carmocca]

noob question: what's the relation to MANIFEST.in? The tests should be excluded:

https://github.com/PyTorchLightning/pytorch-lightning/blob/20f63377f81f4771d3f128f979b3a0f9b8d219a7/MANIFEST.in#L70

Does packages take precedence?

@Borda This might be the fix for https://github.com/PyTorchLightning/internal-dev/issues/132

[Borda]

hmm it is strange for me too, I thought the Manifest is sufficient, but maybe the combination with find_package?

[flying-sheep]

IDK, I no longer try to understand setuptools, and instead use flit or poetry for all my packages. It doesn’t look like you have a build step or some special behavior in setup.py, so that might be a possible choice for you too.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

[carmocca]

GPU tests fail because now that we don't distribute the tests, our examples fail since they rely on our MNIST implementation.

ModuleNotFoundError: No module named 'tests.helpers.datasets'

If possible, I don't think the examples should do that at all as then it's not as easy for users to copy-paste the code and get it running.

But on the other hand, then CI can fail if downloading from torchvision fails.

@Borda save us pls

[Borda]

@flying-sheep mind rebase on master?

[flying-sheep]

Here you go

[flying-sheep]

So what’s up here? Doesn’t seem like your CI feels like playing along?

[carmocca]

Closing as this is blocked by CI limitations. Will be continued in #7614