Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up after logger connector redesign 2/2 #7631

Merged
merged 260 commits into from
Jun 10, 2021
Merged

Clean-up after logger connector redesign 2/2 #7631

merged 260 commits into from
Jun 10, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 20, 2021 •
edited by Borda
Loading

What does this PR do?

Fixes #7183
Fixes #6203

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.4 milestone May 20, 2021
@carmocca carmocca self-assigned this May 20, 2021
@pep8speaks
Copy link

pep8speaks commented May 20, 2021 •
edited
Loading

Hello @carmocca! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-10 11:43:50 UTC

@codecov
Copy link

codecov bot commented May 20, 2021 •
edited
Loading

Codecov Report

Merging #7631 (4950821) into master (07b6923) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7631   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         199     200    +1     
  Lines       12800   12801    +1     
======================================
- Hits        11855   11818   -37     
- Misses        945     983   +38

@rohitgr7 rohitgr7 linked an issue May 21, 2021 that may be closed by this pull request
callback_metrics should be reset when a new epoch start #7558
Closed
@tchaton tchaton marked this pull request as ready for review May 24, 2021 19:26
@tchaton tchaton mentioned this pull request May 25, 2021
Merged
4 tasks
@carmocca carmocca added logging Related to the `LoggerConnector` and `log()` and removed design Includes a design discussion Important feature Is an improvement or enhancement labels Jun 9, 2021
@carmocca carmocca changed the title Logger connector refactor Clean-up after logger connector redesign Jun 9, 2021
@mergify mergify bot removed the has conflicts label Jun 9, 2021
@carmocca carmocca changed the title Clean-up after logger connector redesign Clean-up after logger connector redesign 1/2 Jun 9, 2021
@carmocca carmocca changed the title Clean-up after logger connector redesign 1/2 Clean-up after logger connector redesign 2/2 Jun 9, 2021
@mergify mergify bot removed the has conflicts label Jun 10, 2021
@carmocca carmocca added the ready PRs ready to be merged label Jun 10, 2021
@awaelchli awaelchli enabled auto-merge (squash) June 10, 2021 10:50
tchaton
tchaton approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot removed the has conflicts label Jun 10, 2021
@awaelchli awaelchli merged commit b45a89a into master Jun 10, 2021
@awaelchli awaelchli deleted the refactor/logger-connector-poc branch June 10, 2021 12:09
@rohitgr7 rohitgr7 removed a link to an issue Sep 8, 2021
callback_metrics should be reset when a new epoch start #7558
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@carmocca carmocca

Labels
logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.4
Development

Successfully merging this pull request may close these issues.

LoggerConnector Refactor Flush logger connector metrics on Trainer state change
7 participants
@carmocca @pep8speaks @awaelchli @Borda @SeanNaren @tchaton @justusschock