Skip to content

Conversation

@edenlightning
Copy link
Contributor

@edenlightning edenlightning commented Jun 17, 2021

Closes #8020

@edenlightning edenlightning added the docs Documentation related label Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #8021 (fde2daf) into master (cdcc483) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8021   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         207     207           
  Lines       13484   13484           
======================================
- Hits        12354   12316   -38     
- Misses       1130    1168   +38     

@kaushikb11
Copy link
Contributor

@edenlightning Poonam did similar changes in #8020

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a duplicate of #8020?

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poonam vs Eden let's see who wins the race for the merge ;)

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃 minor comment

Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
@carmocca carmocca enabled auto-merge (squash) June 18, 2021 00:57
@carmocca carmocca merged commit 599d6db into master Jun 18, 2021
@carmocca carmocca deleted the edenlightning-patch-1 branch June 18, 2021 01:24
@carmocca carmocca added this to the v1.4 milestone Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants