Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop Refactor 4/N - Remove Old Evaluation Loop #8056

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Removes the old evaluation loop file.
The new loop was already merged in #7990.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli modified the milestones: v1.3.x, v1.4 Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #8056 (1f3b4f8) into master (92a78d5) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8056    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         210     210            
  Lines       13579   13579            
=======================================
- Hits        12452   11810   -642     
- Misses       1127    1769   +642     

@awaelchli awaelchli changed the title Refactor/loops/remove old eval Loop Refactor 4/N - Remove Old Evaluation Loop Jun 21, 2021
@awaelchli awaelchli marked this pull request as ready for review June 21, 2021 08:24
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 21, 2021
@awaelchli awaelchli mentioned this pull request Jun 21, 2021
11 tasks
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@awaelchli awaelchli enabled auto-merge (squash) June 22, 2021 09:32
@awaelchli awaelchli merged commit 9a64e53 into master Jun 22, 2021
@awaelchli awaelchli deleted the refactor/loops/remove-old-eval branch June 22, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants