Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete checkpoint_connector.has_trained #8292

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 5, 2021

What does this PR do?

Delete flag added in #4291

Considering this flag internal API even though it was not prefixed by an underscore

Part of #7724

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #8292 (4e7cdde) into master (441e16f) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8292   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         213     213           
  Lines       13803   13800    -3     
======================================
- Hits        12803   12732   -71     
- Misses       1000    1068   +68     

@carmocca carmocca added the ready PRs ready to be merged label Jul 7, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca enabled auto-merge (squash) July 7, 2021 15:30
@carmocca carmocca merged commit 0cd406d into master Jul 7, 2021
@carmocca carmocca deleted the refactor/delete-has-trained branch July 7, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants