-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose extract_batch_size
method and add corresponding tests.
#8357
Merged
ananyahjha93
merged 13 commits into
Lightning-AI:master
from
kandluis:bugfix/expose_batch
Jul 13, 2021
Merged
Expose extract_batch_size
method and add corresponding tests.
#8357
ananyahjha93
merged 13 commits into
Lightning-AI:master
from
kandluis:bugfix/expose_batch
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8357 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 216 216
Lines 14097 14099 +2
=======================================
- Hits 13068 12407 -661
- Misses 1029 1692 +663 |
ananthsub
reviewed
Jul 9, 2021
pytorch_lightning/trainer/connectors/logger_connector/result.py
Outdated
Show resolved
Hide resolved
kandluis
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
July 9, 2021 19:51
ananthsub
approved these changes
Jul 9, 2021
Borda
approved these changes
Jul 9, 2021
carmocca
approved these changes
Jul 12, 2021
awaelchli
approved these changes
Jul 12, 2021
…g into bugfix/expose_batch
…htning into bugfix/expose_batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This brings back this API which was made unavailable in #7882. The API is kept stand-alone rather than requiring the
ResultCollection
object.Does your PR introduce any breaking changes ? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃