Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose extract_batch_size method and add corresponding tests. #8357

Merged
merged 13 commits into from
Jul 13, 2021

Conversation

kandluis
Copy link
Contributor

@kandluis kandluis commented Jul 9, 2021

What does this PR do?

This brings back this API which was made unavailable in #7882. The API is kept stand-alone rather than requiring the ResultCollection object.

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #8357 (a519250) into master (f3e8284) will decrease coverage by 5%.
The diff coverage is 94%.

@@           Coverage Diff           @@
##           master   #8357    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         216     216            
  Lines       14097   14099     +2     
=======================================
- Hits        13068   12407   -661     
- Misses       1029    1692   +663     

@kandluis kandluis marked this pull request as ready for review July 9, 2021 19:51
@Borda Borda added the feature Is an improvement or enhancement label Jul 9, 2021
@Borda Borda added ready PRs ready to be merged design Includes a design discussion labels Jul 9, 2021
@ananyahjha93 ananyahjha93 enabled auto-merge (squash) July 12, 2021 21:05
@ananyahjha93 ananyahjha93 merged commit 000fbe6 into Lightning-AI:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants