-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude mpi run from auto-detection of horovod #8610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8610 +/- ##
=======================================
- Coverage 93% 88% -4%
=======================================
Files 168 168
Lines 13951 13951
=======================================
- Hits 12909 12315 -594
- Misses 1042 1636 +594 |
tchaton
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch !
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
July 29, 2021 08:18
Borda
approved these changes
Jul 29, 2021
justusschock
approved these changes
Jul 30, 2021
awaelchli
force-pushed
the
bugfix/horovodrun-detection
branch
from
July 30, 2021 07:33
33b6407
to
a1542b3
Compare
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
added a commit
that referenced
this pull request
Aug 3, 2021
lexierule
pushed a commit
that referenced
this pull request
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8573
Horovod can be launched by either horovodrun (convenience utility) or by equivalent commands through mpirun directly (see docs). However, since mpirun is a general purpose HPC technology we probably don't want to autodetect horovod unless horovod is actually installed.
I'm very unfamiliar with the details of the mpirun + horovod usage, so suggestions are welcome.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
it is not installed. If you have any ideas, please let me know.
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃