Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude mpi run from auto-detection of horovod #8610

Merged
merged 4 commits into from
Jul 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 29, 2021

What does this PR do?

Fixes #8573

Horovod can be launched by either horovodrun (convenience utility) or by equivalent commands through mpirun directly (see docs). However, since mpirun is a general purpose HPC technology we probably don't want to autodetect horovod unless horovod is actually installed.

I'm very unfamiliar with the details of the mpirun + horovod usage, so suggestions are welcome.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
    • No, suggestions welcome. I tried to write a test but having trouble mocking the horovod imports pretending
      it is not installed. If you have any ideas, please let me know.
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Jul 29, 2021
@awaelchli awaelchli modified the milestone: v1.4.x Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8610 (a1542b3) into master (c99e2fe) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8610    +/-   ##
=======================================
- Coverage      93%     88%    -4%     
=======================================
  Files         168     168            
  Lines       13951   13951            
=======================================
- Hits        12909   12315   -594     
- Misses       1042    1636   +594     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@awaelchli awaelchli marked this pull request as ready for review July 29, 2021 08:18
@mergify mergify bot added the ready PRs ready to be merged label Jul 29, 2021
@awaelchli awaelchli added this to the v1.4.x milestone Jul 29, 2021
@awaelchli awaelchli force-pushed the bugfix/horovodrun-detection branch from 33b6407 to a1542b3 Compare July 30, 2021 07:33
@awaelchli awaelchli merged commit b6ea637 into master Jul 30, 2021
@awaelchli awaelchli deleted the bugfix/horovodrun-detection branch July 30, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLURM mpirun/openmpi training selects horovod automatically when not requested
4 participants