Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 2/n Add Fault Tolerant Training to LightningFetcher #8891

Merged
merged 29 commits into from
Aug 17, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 13, 2021

What does this PR do?

This PR adds fault tolerant support to the LightningFetcher.

Blocked by #8890

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@tchaton tchaton changed the base branch from master to add_lightning_prefetcher August 13, 2021 16:38
@tchaton tchaton self-assigned this Aug 13, 2021
@tchaton tchaton added this to the v1.5 milestone Aug 13, 2021
@tchaton tchaton added the feature Is an improvement or enhancement label Aug 13, 2021
@tchaton tchaton marked this pull request as ready for review August 13, 2021 16:39
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #8891 (0254043) into master (de22e40) will decrease coverage by 5%.
The diff coverage is 52%.

@@           Coverage Diff           @@
##           master   #8891    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         176     176            
  Lines       14270   14394   +124     
=======================================
- Hits        13260   12695   -565     
- Misses       1010    1699   +689     

@tchaton tchaton mentioned this pull request Aug 14, 2021
12 tasks
Base automatically changed from add_lightning_prefetcher to master August 16, 2021 16:02
@mergify mergify bot removed the has conflicts label Aug 16, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/utilities/apply_func.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
awaelchli and others added 5 commits August 17, 2021 15:36
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@awaelchli awaelchli disabled auto-merge August 17, 2021 13:52
@awaelchli awaelchli enabled auto-merge (squash) August 17, 2021 13:52
@awaelchli awaelchli requested a review from Borda August 17, 2021 16:23
@awaelchli awaelchli merged commit 19136ac into master Aug 17, 2021
@awaelchli awaelchli deleted the add_lightning_prefetcher_2_n branch August 17, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants