Add an issue template for Code Improvement

[daniellepintz]

This will allow people to create an issue for a refactor or deprecation

What does this PR do?

Currently if someone wants to make an issue for a refactoring or deprecation there is no option for this in the issue templates. This PR creates a template for a refactor/deprecation

Discussed in slack: https://app.slack.com/client/TR9DVT48M/C01296PBDQV/thread/C01296PBDQV-1629162951.025000

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #8960 (a1f291c) into master (77bc5d4) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8960    +/-   ##
=======================================
- Coverage      92%     89%    -4%     
=======================================
  Files         176     175     -1     
  Lines       14394   14402     +8     
=======================================
- Hits        13275   12762   -513     
- Misses       1119    1640   +521     

[yifuwang]

This looks great! Thanks for proposing this.

Would it be better to call this "improvement" instead? IMHO refactoring is a means for improvement but itself is not an end.

[daniellepintz]

Good call @yifuwang how about "Code Improvement"? That encapsulates deprecation and refactoring

[yifuwang]

Thanks @daniellepintz! This sounds great

[ananthsub]

Looks reasonable to me! And glad that we're capturing these separately from bug reports and feature requests

[Borda]

feeling a bit confused, this looks almost the same as the feature request...

[daniellepintz]

@Borda you are right, it is almost the same. But this way when creating an issue there is an option for code improvement, as currently a lot of issues don't fall under the "feature" or "bug fix" category. One alternative is we could rename "Feature" to something to encapsulate feature, refactoring, and deprecation, but it might be a bit strange to just have a generic catch-all category. wdyt?

[daniellepintz]

@Borda @tchaton @edenlightning looks like I need a review from one of you to merge this. wdyt?