Remove unused on_train_epoch_end
hook in accelerator
#9035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are auditing the Lightning components and APIs to assess opportunities for improvements:
No plugins or accelerators override this. Based on discussion in #9023: the plugins & accelerator API is not stable enough yet for it to warrant full backward compatibility. the blast radius of this change is small given none of the framework's implementations are affected. Therefore, I'm directly removing this hook instead of going through a full deprecation cycle.
A more composable, (currently half-baked) approach could be:
ModelHooks
into separate abstract classes that constitute pure interfaces.Trainer.call_hook
to actually run these hooks for components that opt-into using them them (could be stronger than thehasattr
checks we have now @carmocca )Does your PR introduce any breaking changes? If yes, please list them.
Yes. This removes
on_train_epoch_end
from the accelerator API. Custom accelerators not directly provided by the framework which were overriding this will no longer have this method called.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃