-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Simplify checkpoint connector loading after Checkpoint IO plugin's introduction #9045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ananthsub
merged 6 commits into
Lightning-AI:master
from
ananthsub:fix/rename-load-checkpoint-plugin
Aug 23, 2021
Merged
Simplify checkpoint connector loading after Checkpoint IO plugin's introduction #9045
ananthsub
merged 6 commits into
Lightning-AI:master
from
ananthsub:fix/rename-load-checkpoint-plugin
Aug 23, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9045 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 175 175
Lines 14379 14457 +78
=======================================
- Hits 13322 12806 -516
- Misses 1057 1651 +594 |
awaelchli
approved these changes
Aug 23, 2021
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
SeanNaren
approved these changes
Aug 23, 2021
ethanwharris
approved these changes
Aug 23, 2021
carmocca
approved these changes
Aug 23, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
tchaton
approved these changes
Aug 23, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
checkpointing
Related to checkpointing
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
load_checkpoint_filein the training type toload_checkpointfor consistency with the checkpoint IO's APIDoes your PR introduce any breaking changes? If yes, please list them.
This is a breaking change for any custom plugin that extended
load_checkpoint_fileas this has been renamed toload_checkpointwith this PRBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃