-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CPU AMP autocast #9084
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9084 +/- ##
======================================
Coverage 92% 92%
======================================
Files 176 176
Lines 14663 14666 +3
======================================
+ Hits 13496 13500 +4
+ Misses 1167 1166 -1 |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dope !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
@SeanNaren I think this PR caused the following 5 tests to fail in our CI job (conda 3.7, 1.10)
The issue tracking this is #9280 Stack traces for the failing tests can be found in this gist: https://gist.github.com/daniellepintz/3d5a13b6264a832fc745f73460d2fa23 (from https://github.com/PyTorchLightning/pytorch-lightning/runs/3483032531) Do you know what might be causing these failures? |
What does this PR do?
Adds PyTorch 1.10 support for CPU autocast. Requires installing 1.10 (and I noticed that for now till the release, we have to include a dev check to the availability for people using nightly or building from source).
Now in 1.10 this works:
cc @ananthsub @anj-s @min-xu-ai I noticed that torch.cpu.autocast only has
bf16
support which means it might not play well withfp16
mode for FSDP when using CPU offloading. Would be nice to have support for this out the box!Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃