Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpu features #932

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Tpu features #932

merged 3 commits into from
Feb 25, 2020

Conversation

williamFalcon
Copy link
Contributor

Fixes #902

@williamFalcon williamFalcon merged commit 2b5293d into master Feb 25, 2020
@williamFalcon williamFalcon deleted the tpu_fix branch February 25, 2020 03:31
@Borda Borda added this to the 0.6.1 milestone Feb 25, 2020
@Borda Borda added the feature Is an improvement or enhancement label Feb 25, 2020
Borda
Borda reviewed Feb 25, 2020
View reviewed changes
pytorch_lightning/core/lightning.py

"""
if self.trainer.proc_rank == 0:
print(*args, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather use logging.info/debug

tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@williamFalcon @tullie
Tpu features (Lightning-AI#932)
ab9a0e3 
* added guide

* added self.print()

* added self.print()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.7
Development

Successfully merging this pull request may close these issues.

TPU Training Issues and Feature Requests
2 participants
@williamFalcon @Borda