Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ModelSummary Callback #9344

Merged
merged 17 commits into from
Sep 10, 2021
Merged

feat: Add ModelSummary Callback #9344

merged 17 commits into from
Sep 10, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Sep 6, 2021

What does this PR do?

There are two parts to #9043

  1. Introduce ModelSummary callback
  2. Support flag weights_summary as Union[str, bool] = True and mark the string values as deprecated (follow up PR)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 self-assigned this Sep 10, 2021
@kaushikb11 kaushikb11 added callback feature Is an improvement or enhancement labels Sep 10, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review September 10, 2021 08:26
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/callbacks/model_summary.py Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
pytorch_lightning/utilities/model_summary.py Show resolved Hide resolved
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify mergify bot added the ready PRs ready to be merged label Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #9344 (a0760c8) into master (c963bf6) will increase coverage by 0%.
The diff coverage is 98%.

@@          Coverage Diff           @@
##           master   #9344   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     180    +1     
  Lines       14927   14963   +36     
======================================
+ Hits        13868   13902   +34     
- Misses       1059    1061    +2     

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

pytorch_lightning/callbacks/model_summary.py Outdated Show resolved Hide resolved
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
@kaushikb11 kaushikb11 enabled auto-merge (squash) September 10, 2021 11:40
@kaushikb11 kaushikb11 merged commit d773407 into master Sep 10, 2021
@kaushikb11 kaushikb11 deleted the callback/model_summary branch September 10, 2021 12:42
@awaelchli awaelchli mentioned this pull request Sep 11, 2021
11 tasks
@ethanwharris ethanwharris added this to the v1.5 milestone Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants