-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ModelSummary Callback #9344
Conversation
for more information, see https://pre-commit.ci
…ghtning/pytorch-lightning into callback/model_summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Codecov Report
@@ Coverage Diff @@
## master #9344 +/- ##
======================================
Coverage 93% 93%
======================================
Files 179 180 +1
Lines 14927 14963 +36
======================================
+ Hits 13868 13902 +34
- Misses 1059 1061 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comment
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
What does this PR do?
There are two parts to #9043
ModelSummary
callbackweights_summary
as Union[str, bool] = True and mark the string values as deprecated (follow up PR)Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃