Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Tests] Fix Pytorch 1.10 autocast failing tests #9345

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 6, 2021

What does this PR do?

The signature for CPU autocast has also changed, hence we need to update the requirements check to the same as bfloat16. I've also updated a test which seems I missed in the initial integration!

Related #9280

cc @daniellepintz

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren self-assigned this Sep 6, 2021
@SeanNaren SeanNaren added the ci Continuous Integration label Sep 6, 2021
@SeanNaren SeanNaren added this to the v1.4.x milestone Sep 6, 2021
@SeanNaren SeanNaren changed the title [Ci/Tests] Fix Pytorch 1.10 autocast failing tests [CI/Tests] Fix Pytorch 1.10 autocast failing tests Sep 6, 2021
@SeanNaren SeanNaren modified the milestones: v1.4.x, v1.5 Sep 6, 2021
@SeanNaren SeanNaren marked this pull request as ready for review September 6, 2021 09:51
@SeanNaren
Copy link
Contributor Author

Tests are passing for autocast now, just quantization tests are failing.

@SeanNaren SeanNaren enabled auto-merge (squash) September 6, 2021 09:52
@mergify mergify bot added the ready PRs ready to be merged label Sep 6, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SeanNaren SeanNaren merged commit 72bb018 into master Sep 6, 2021
@SeanNaren SeanNaren deleted the fix/1.10_tests branch September 6, 2021 11:58
@daniellepintz
Copy link
Contributor

thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants