Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Revert inference mode support #9443

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Sep 10, 2021

What does this PR do?

Fixes #9431
Reverts #8813 until torchmetrics integration is sorted out

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub changed the title Revert #8813 [bugfix] Revert inference mode support Sep 10, 2021
@awaelchli awaelchli added the feature Is an improvement or enhancement label Sep 10, 2021
@ananthsub ananthsub added bug Something isn't working and removed feature Is an improvement or enhancement labels Sep 10, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 10, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #9443 (e5186b5) into master (15434a9) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9443    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         180     180            
  Lines       15046   15041     -5     
=======================================
- Hits        13971   13353   -618     
- Misses       1075    1688   +613     

@ananthsub ananthsub enabled auto-merge (squash) September 10, 2021 20:37
@ananthsub ananthsub merged commit d2def36 into Lightning-AI:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torchmetrics.Accuracy doesn't support inference mode with distributed backend.
4 participants