Changed `max_steps` default from None to -1#9460

Merged

rohitgr7 merged 33 commits intoLightning-AI:masterfrom EricWiener:feature/clean_up_max_steps_epochs

Oct 25, 2021

+94-58

Commits on Oct 21, 2021

Changed max_steps to default to -1

EricWiener
authored and
rohitgr7
committed
Update fit_loop max_epoch's docstring

authored and
rohitgr7
committed
Changes fit_loop signature to have max_epochs = -1, min_epochs = 0

authored and
rohitgr7
committed
Added deprecation warning + is_max_limit_reached util

EricWiener
authored and
rohitgr7
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
rohitgr7
committed
Remove checking if max_epochs is less than -1

EricWiener
authored and
rohitgr7
committed
Remove Optional from max_steps signature

authored and
rohitgr7
committed
Update trainer docstring for max_steps

authored and
rohitgr7
committed
Make is_max_limit_reached private

EricWiener
authored and
rohitgr7
committed
Move max_steps validation to training_epoch_loop

EricWiener
authored and
rohitgr7
committed
Moved max_epochs logic into fit_loop

EricWiener
authored and
rohitgr7
committed
Updated logic for checking max_epochs in fit_loop

EricWiener
authored and
rohitgr7
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
rohitgr7
committed
Checkpoint connector passes mypy

EricWiener
authored and
rohitgr7
committed
Cleaned up checkpoint connector if

EricWiener
authored and
rohitgr7
committed
Removed ClosureResult from bad merge

EricWiener
authored and
rohitgr7
committed
Changed positive int to non-negative int

EricWiener
authored and
rohitgr7
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
rohitgr7
committed
fix expected values in trainer test

awaelchli
authored and
rohitgr7
committed
update cli tests

awaelchli
authored and
rohitgr7
committed
update utility function signature and docstring

awaelchli
authored and
rohitgr7
committed
move max_epochs=None parsing back to trainer

awaelchli
authored and
rohitgr7
committed
update epoch loop signature and deprecation message

awaelchli
authored and
rohitgr7
committed
update fit loop max_steps signature and deprecation message

awaelchli
authored and
rohitgr7
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
rohitgr7
committed
rebase and update tests
rohitgr7
committed
fix issues
rohitgr7
committed
mypy
rohitgr7
committed
update changelog

awaelchli
authored and
rohitgr7
committed

Commits on Oct 22, 2021

update mypy and error msg
rohitgr7
committed

Commits on Oct 25, 2021