Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Avoid warning when configure_optimizers will not be overridden #9583

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

See added test
Part of #9565

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working argparse (removed) Related to argument parsing (argparse, Hydra, ...) labels Sep 17, 2021
@carmocca carmocca added this to the v1.5 milestone Sep 17, 2021
@carmocca carmocca self-assigned this Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #9583 (7916e24) into master (856ed10) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9583    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         181     182     +1     
  Lines       15295   15412   +117     
=======================================
+ Hits        14211   14303    +92     
- Misses       1084    1109    +25     

@carmocca carmocca enabled auto-merge (squash) September 17, 2021 23:25
@carmocca carmocca changed the title Avoid CLI warning when configure_optimizers will not be overridden [CLI] Avoid warning when configure_optimizers will not be overridden Sep 17, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

@mergify mergify bot added the ready PRs ready to be merged label Sep 18, 2021
@carmocca carmocca merged commit 61b4e33 into master Sep 21, 2021
@carmocca carmocca deleted the bugfix/cli-avoid-warninig branch September 21, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants