Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support skipping to validation #9681

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Part of #9563

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement fault tolerance progress tracking (internal) Related to the progress tracking dataclasses labels Sep 24, 2021
@carmocca carmocca added this to the v1.5 milestone Sep 24, 2021
@carmocca carmocca self-assigned this Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #9681 (a6c00c6) into master (41e3be1) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9681   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     179           
  Lines       15306   15374   +68     
======================================
+ Hits        14199   14265   +66     
- Misses       1107    1109    +2     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Let's not forget the TODOs

@mergify mergify bot added the ready PRs ready to be merged label Sep 24, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@carmocca carmocca enabled auto-merge (squash) September 24, 2021 13:36
@carmocca carmocca merged commit ce00053 into master Sep 24, 2021
@carmocca carmocca deleted the feat/support-skipping-to-val branch September 24, 2021 14:10
@carmocca carmocca mentioned this pull request Sep 24, 2021
38 tasks
lantiga added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fault tolerance feature Is an improvement or enhancement progress tracking (internal) Related to the progress tracking dataclasses ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants