Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dataloader patching on the LightningModule #9764

Merged
merged 57 commits into from
Oct 20, 2021
Merged

remove dataloader patching on the LightningModule #9764

Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
874614f
draft
awaelchli Sep 29, 2021
6d6b3ea
draft
awaelchli Sep 29, 2021
a10c526
clean up
awaelchli Sep 29, 2021
a1c5537
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 29, 2021
5c36fbc
check availability of val/test dataloader
awaelchli Sep 29, 2021
84086e6
availability check / property
awaelchli Sep 29, 2021
5d93ee4
hack around on tpu test
awaelchli Sep 30, 2021
7b19d5e
fix test_dataloaders_reset_and_attach test
awaelchli Sep 30, 2021
1fc7c2a
wip
awaelchli Sep 30, 2021
3e05cfc
specify error message in test
awaelchli Sep 30, 2021
35bb187
fix scale batch size test
awaelchli Sep 30, 2021
37dddfc
remove patch_loader_code check from is_overridden util
awaelchli Sep 30, 2021
e8b8dcb
remove patch_loader_code reference from plugins registry
awaelchli Sep 30, 2021
91c24db
add is_module method
awaelchli Sep 30, 2021
5af46ce
update tests for is_module() check
awaelchli Sep 30, 2021
921e5d8
Merge branch 'master' into feature/remove-dataloader-patching
awaelchli Oct 11, 2021
a8d4a26
update tests
awaelchli Oct 11, 2021
8da6bfc
fix unused imports
awaelchli Oct 11, 2021
791ee39
update unit tests to use attach data function
awaelchli Oct 11, 2021
54c1086
use dataloader from trainer
awaelchli Oct 11, 2021
28b95ee
fix test not using the right dataloader
awaelchli Oct 11, 2021
5d76890
fix test
awaelchli Oct 12, 2021
8d8f817
fix test
awaelchli Oct 12, 2021
7881a5d
remove redundant fixme comment
awaelchli Oct 12, 2021
7916083
remove comment
awaelchli Oct 12, 2021
062de83
Merge branch 'master' into feature/remove-dataloader-patching
awaelchli Oct 12, 2021
7ec1b5c
update
awaelchli Oct 12, 2021
66e1e47
Merge branch 'master' into feature/remove-dataloader-patching
awaelchli Oct 12, 2021
abc8bf6
rename dataloader source
awaelchli Oct 12, 2021
5587ea4
typing dataloaders
awaelchli Oct 12, 2021
4baa4da
add docs
awaelchli Oct 12, 2021
6cca816
update changelog
awaelchli Oct 12, 2021
caa869b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 12, 2021
ccbe477
add unit tests
awaelchli Oct 12, 2021
3628ba6
Merge remote-tracking branch 'origin/feature/remove-dataloader-patchi…
awaelchli Oct 12, 2021
909489c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 12, 2021
8dbb918
delete methods
awaelchli Oct 12, 2021
bcd376e
Merge remote-tracking branch 'origin/feature/remove-dataloader-patchi…
awaelchli Oct 12, 2021
c496779
address fixme
awaelchli Oct 12, 2021
ff906c1
val sanity
rohitgr7 Oct 12, 2021
fb0f347
val sanity
rohitgr7 Oct 12, 2021
2f2a431
is_available
awaelchli Oct 14, 2021
f3bb2fb
simplify
awaelchli Oct 14, 2021
a68bbe3
use call_hook() for LightningModule
awaelchli Oct 14, 2021
02d01e4
Merge branch 'master' into feature/remove-dataloader-patching
awaelchli Oct 14, 2021
c355a9d
ensure model has a trainer in unit tests
awaelchli Oct 14, 2021
3052405
fix deepspeed dl request
rohitgr7 Oct 14, 2021
535f423
Apply suggestions from code review
awaelchli Oct 14, 2021
5f9b699
Update pytorch_lightning/utilities/model_helpers.py
awaelchli Oct 14, 2021
2e0496e
rename is_available
awaelchli Oct 14, 2021
c264368
Merge branch 'master' into feature/remove-dataloader-patching
awaelchli Oct 20, 2021
c56eb60
resolve merge error
awaelchli Oct 20, 2021
7fc97ed
address reviews
awaelchli Oct 20, 2021
c194b44
rename reqest -> dataloader
awaelchli Oct 20, 2021
7883b22
update predict check
awaelchli Oct 20, 2021
b8e8034
fix bug in example
awaelchli Oct 20, 2021
4fb6081
add datamodules test() and predict() calls, otherwise loops get skipp…
awaelchli Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pl_examples/basic_examples/backbone_image_classifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def cli_main():
cli = LightningCLI(LitClassifier, MyDataModule, seed_everything_default=1234, save_config_overwrite=True, run=False)
cli.trainer.fit(cli.model, datamodule=cli.datamodule)
cli.trainer.test(ckpt_path="best")
predictions = cli.trainer.predict(ckpt_path="best")
predictions = cli.trainer.predict(ckpt_path="best", datamodule=cli.datamodule)
print(predictions[0])


Expand Down