Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type error handling in _configure_checkpoint_callbacks #9823

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Oct 5, 2021

What does this PR do?

Resolving a TODO in the code for v1.5

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Oct 12, 2021
@mergify mergify bot requested a review from a team October 12, 2021 19:40
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 12, 2021 19:42
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #9823 (9e0b42f) into master (dc27c72) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9823    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         178     178            
  Lines       15650   15645     -5     
=======================================
- Hits        14508   13894   -614     
- Misses       1142    1751   +609     

@rohitgr7 rohitgr7 merged commit dd6d797 into Lightning-AI:master Oct 12, 2021
@daniellepintz daniellepintz deleted the checkpoint branch October 12, 2021 22:14
rohitgr7 added a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
…ing-AI#9823)

* remove type error handling in _configure_checkpoint_callbacks

* rm test

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants