Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for torch.set_detect_anomaly #9848

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Oct 7, 2021

What does this PR do?

This carries forward #9175 which has gone stale. I'm creating a separate PR because the v1.5 release is coming soon, and I'm unsure whether the OP of #9175 has time to address the reviews before the release.
Fixes #8313

Note to reviewers: This intentionally does not deprecate terminate_on_nan. To ensure this PR only does one thing, I will create a separate PR to deprecate terminate_on_nan (#9849)

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli
Copy link
Contributor

Let's keep #9175 and merge it after this one with the remaining changes? I'll assign myself to update the PR if it's ok.

@mergify mergify bot added the ready PRs ready to be merged label Oct 7, 2021
@ananthsub ananthsub force-pushed the feat/add-detect-anomaly branch from 4333152 to 773d739 Compare October 7, 2021 15:31
@ananthsub ananthsub enabled auto-merge (squash) October 7, 2021 15:34
@ananthsub ananthsub merged commit 5206e52 into Lightning-AI:master Oct 7, 2021
@ananthsub ananthsub deleted the feat/add-detect-anomaly branch October 7, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argument for detect_anomaly on for debug
4 participants