Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PrecisionPlugin.forward_context() #9988

Merged
merged 4 commits into from
Oct 18, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 18, 2021

What does this PR do?

Adds a new method forward_context and simplifies duplicated implementations across inherited plugins for train_step_context, etc.

Part of #9987

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added this to the v1.5 milestone Oct 18, 2021
@awaelchli awaelchli added refactor design Includes a design discussion labels Oct 18, 2021
@awaelchli awaelchli changed the title introduce PrecisionPlugin.forward_context() Introduce PrecisionPlugin.forward_context() Oct 18, 2021
@awaelchli awaelchli mentioned this pull request Oct 18, 2021
23 tasks
@awaelchli awaelchli marked this pull request as ready for review October 18, 2021 12:13
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 18, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
@awaelchli awaelchli enabled auto-merge (squash) October 18, 2021 12:25
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #9988 (7fe463e) into master (8c76cf5) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9988    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         179     179            
  Lines       15830   15804    -26     
=======================================
+ Hits        14056   14642   +586     
+ Misses       1774    1162   -612     

@awaelchli awaelchli merged commit 10d0b41 into master Oct 18, 2021
@awaelchli awaelchli deleted the lightning-lite/refactors/forward-context branch October 18, 2021 12:58
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants