Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LightningLite Example #9991

Merged
merged 21 commits into from
Oct 19, 2021
Merged

Add LightningLite Example #9991

merged 21 commits into from
Oct 19, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 18, 2021

What does this PR do?

This PR adds an example to use LightningLite with the BoringModel

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Oct 18, 2021
@tchaton tchaton modified the milestones: v1.6, v1.5 Oct 18, 2021
@tchaton tchaton changed the base branch from master to lite-poc October 18, 2021 13:11
@mergify mergify bot removed the has conflicts label Oct 18, 2021
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: still reading

pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
pl_examples/lite_examples/pytorch_2_lite_2_lightning.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 18, 2021
@mergify mergify bot removed the has conflicts label Oct 18, 2021
Copy link
Contributor

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First thing that came to my mind when I saw LightningLite, was Tensorflow Lite. I thought the naming could have been better. But I am sure you folks have already gone through this multiple time before took this call. LGTM anyways. Nice stuff

@awaelchli awaelchli merged commit 61c825c into lite-poc Oct 19, 2021
@awaelchli awaelchli deleted the testing_lite branch October 19, 2021 10:21
This was referenced Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants