Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement own metrics or use lighter packages #433

Closed
Borda opened this issue Aug 8, 2021 · 4 comments
Closed

implement own metrics or use lighter packages #433

Borda opened this issue Aug 8, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Important milestonish refactoring refactoring and code health

Comments

@Borda
Copy link
Member

Borda commented Aug 8, 2021

🚀 Feature

revisit 3rd-party dependencies and if possible make own implementation or use a lighter package

Motivation

keep the TM dependency light, and use other packages only as a reference

Pitch

Alternatives

use another package that has less dependencies and still use this one as reference

Additional context

https://github.com/PyTorchLightning/metrics/blob/525642df8c3f3f5f93cdd22b6b9cd802a3854634/requirements/image.txt#L3

https://github.com/PyTorchLightning/metrics/blob/525642df8c3f3f5f93cdd22b6b9cd802a3854634/requirements/text.txt#L1-L3

Particular tasks:

@Borda Borda added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Important milestonish refactoring refactoring and code health labels Aug 8, 2021
@Borda Borda pinned this issue Aug 8, 2021
@stancld
Copy link
Contributor

stancld commented Aug 11, 2021

@Borda May I have a look at the rouge_score metric?

@Borda
Copy link
Member Author

Borda commented Aug 11, 2021

@Borda May I have a look at the rouge_score metric?

that would be great! looking forward to see draft PR 🐰

@kingyiusuen
Copy link
Contributor

@Borda I'd love to contribute to this project. Do you mind if I work on the WER metric to remove the dependency of jiwer?

@Borda
Copy link
Member Author

Borda commented Aug 14, 2021

Do you mind if I work on the WER metric to remove the dependency of jiwer?

wow, that you, that would be really great! 🐰
cc: @SeanNaren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Important milestonish refactoring refactoring and code health
Projects
None yet
Development

No branches or pull requests

4 participants