Add torchmetrics' own implementation of Rouge score metrics
#443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with whitespaces at the end of the sentence * Remove newline_sep argument -> TODO: add deprecated/removal warning * Clean some minor stuff
|
Hello @stancld! Thanks for updating this PR.
Comment last updated at 2021-08-13 12:11:13 UTC |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* Fix some documentation issues * Enable _rouge_score_update method takes List of sentence_results
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 74.79% 74.94% +0.15%
==========================================
Files 129 129
Lines 4178 4227 +49
==========================================
+ Hits 3125 3168 +43
- Misses 1053 1059 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stancld
requested review from
ananyahjha93,
Borda and
justusschock
as code owners
4 tasks
Borda
approved these changes
Aug 15, 2021
SeanNaren
approved these changes
Aug 16, 2021
SkafteNicki
reviewed
Aug 16, 2021
justusschock
approved these changes
Aug 16, 2021
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
SkafteNicki
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
This PR is a part of the endeavour of #433 to implement own metrics and minimize third-party dependencies. It adds the own implementation of Rouge score metrics.
In this PR, the
rouge-scorepackage (https://pypi.org/project/rouge-score/) is replaced withtorchmetrics' own implementation. The behaviour of this new implementation should be equivalent tothe aforementioned package.Furthermore, this PR strips the use of the
decimal_placesargument as this seems not to be used by any other metric. TODO: Add some depreciation warning (I will need a help here as I haven't found any own Warning class as it is the case in thepytorch-lightning.Future TODOs for another PR: Replace
nltkpackage (I will need to dig a bit deeper to find out if there's a way)PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Reviewers: @Borda @SkafteNicki
Did you have fun?
Make sure you had fun coding 🙃