MAP: change bool to float32 #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreaquil
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
|
hi @dreaquil, mind share motivation or what does it solves? |
|
Hi @Borda! This is to resolve this issue #1147. However, there is some missing test for this failure. I would like to add a test but I am unable to get my development environment set up for test discovery in Vscode. Dealing with this issue: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1150 +/- ##
========================================
- Coverage 86% 34% -51%
========================================
Files 195 195
Lines 11463 11463
========================================
- Hits 9836 3935 -5901
- Misses 1627 7528 +5901 |
Borda
reviewed
Jul 19, 2022
raghavmecheri
added a commit
to raghavmecheri/lightning-metrics
that referenced
this pull request
Aug 8, 2022
Merging in [MAP: change bool to float32](Lightning-AI#1150)
|
Any update on this PR? |
justusschock
approved these changes
Oct 11, 2022
SkafteNicki
approved these changes
Oct 11, 2022
Borda
pushed a commit
that referenced
this pull request
Oct 21, 2022
* Change bool to float32. * add test case * changelog Co-authored-by: André Aquilina <andre.aquilina@dysismedical.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: thomas chaton <thomas@grid.ai> (cherry picked from commit d3c4c82)
Borda
pushed a commit
that referenced
this pull request
Oct 21, 2022
* Change bool to float32. * add test case * changelog Co-authored-by: André Aquilina <andre.aquilina@dysismedical.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: thomas chaton <thomas@grid.ai> (cherry picked from commit d3c4c82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1147
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃