-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multioutput pearson and spearman corrcoef #1200
Conversation
Seems that the assertion comparison fails... |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
========================================
- Coverage 86% 36% -50%
========================================
Files 191 191
Lines 11332 11342 +10
========================================
- Hits 9709 4028 -5681
- Misses 1623 7314 +5691 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also get tests that exceptions are raised for wrong configurations?
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
There was an error handling pipeline event 731315bb-5dfe-468e-bdd2-706997066433. |
…rchLightning/metrics into feature/2d_pearson_spearman
They are already there: |
@justusschock @stancld mind have look ^^ 🦦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only some minor comments -- I'm a bit worried the error message raised wouldn't be clear.
@justusschock pls ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR do?
Fixes #1177
Adds support in
spearman
andpearson
correlation coefficient metrics for 2d arrays (multioutput).Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃