Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalize arg to LPIPS metric #1216

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Add normalize arg to LPIPS metric #1216

merged 4 commits into from
Sep 13, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 13, 2022

What does this PR do?

Fixes #1214
Add support for the normalize argument in the backend of the lpips metric

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Sep 13, 2022
@SkafteNicki SkafteNicki added this to the v0.11 milestone Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1216 (c9c5506) into master (ebdaea7) will decrease coverage by 49%.
The diff coverage is 88%.

@@           Coverage Diff            @@
##           master   #1216     +/-   ##
========================================
- Coverage      86%     37%    -49%     
========================================
  Files         191     191             
  Lines       11312   11316      +4     
========================================
- Hits         9693    4207   -5486     
- Misses       1619    7109   +5490     

@SkafteNicki SkafteNicki changed the title add normalize arg Add normalize arg to LPIPS metric Sep 13, 2022
@mergify mergify bot added the ready label Sep 13, 2022
@SkafteNicki SkafteNicki modified the milestones: v0.11, v0.10 Sep 13, 2022
@Borda Borda merged commit 8086097 into master Sep 13, 2022
@Borda Borda deleted the feature/lpips_normalize branch September 13, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The LPIPS Module Has a Normalize Parameter
3 participants