Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix compute when called on empty lists #1219

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

geoffrey-g-delhomme
Copy link
Contributor

@geoffrey-g-delhomme geoffrey-g-delhomme commented Sep 13, 2022

What does this PR do?

Fixes #1218

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda changed the title fix #1218 fix list index out of range Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1219 (a89f121) into master (8086097) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1219   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files         191     191           
  Lines       11316   11318    +2     
======================================
+ Hits         9696    9698    +2     
  Misses       1620    1620           

@SkafteNicki
Copy link
Member

Hi @geoffrey-g-delhomme,
Would it be possible to add a test for this case that are currently failing on master but will be fixed by this PR? :)

@Borda Borda added the bug / fix Something isn't working label Sep 15, 2022
@SkafteNicki SkafteNicki changed the title fix list index out of range Bugfix: fix compute when called on empty lists Sep 15, 2022
@mergify mergify bot added the ready label Sep 15, 2022
@Borda Borda enabled auto-merge (squash) September 15, 2022 15:27
@Borda Borda merged commit 3fd3dc4 into Lightning-AI:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list index out of range in _sync_dist
3 participants