Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing agains each feat PT version #127

Merged
merged 8 commits into from
Mar 25, 2021
Merged

Add testing agains each feat PT version #127

merged 8 commits into from
Mar 25, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 24, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #125

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request test / CI testing or CI labels Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #127 (042c191) into master (2601642) will decrease coverage by 0.37%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   96.61%   96.24%   -0.38%     
==========================================
  Files         140       70      -70     
  Lines        4376     2210    -2166     
==========================================
- Hits         4228     2127    -2101     
+ Misses        148       83      -65     
Flag Coverage Δ
Linux 78.77% <72.72%> (-0.07%) ⬇️
Windows 78.77% <72.72%> (-0.07%) ⬇️
cpu 96.24% <72.72%> (-0.24%) ⬇️
gpu ?
macOS 96.24% <72.72%> (-0.24%) ⬇️
pytest 96.24% <72.72%> (-0.38%) ⬇️
python3.6 96.23% <72.72%> (-0.24%) ⬇️
python3.8 96.24% <72.72%> (-0.24%) ⬇️
python3.9 96.24% <72.72%> (-0.24%) ⬇️
torch1.3.1 94.96% <72.72%> (-0.23%) ⬇️
torch1.4.0 95.11% <72.72%> (-0.23%) ⬇️
torch1.8.1 96.24% <72.72%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/utilities/imports.py 77.77% <72.72%> (-22.23%) ⬇️
__w/1/s/torchmetrics/utilities/__init__.py
__w/1/s/torchmetrics/classification/roc.py
...s/torchmetrics/classification/matthews_corrcoef.py
...etrics/functional/regression/explained_variance.py
...hmetrics/functional/retrieval/average_precision.py
...s/torchmetrics/classification/average_precision.py
__w/1/s/torchmetrics/classification/checks.py
...torchmetrics/functional/classification/__init__.py
__w/1/s/torchmetrics/classification/__init__.py
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2601642...042c191. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Mar 25, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-25 19:17:17 UTC

@Borda Borda marked this pull request as ready for review March 25, 2021 01:01
@Borda Borda requested a review from a team March 25, 2021 01:01
@Borda Borda marked this pull request as draft March 25, 2021 10:57
@Borda Borda marked this pull request as ready for review March 25, 2021 12:58
@Borda Borda enabled auto-merge (squash) March 25, 2021 13:25
tests/retrieval/test_map.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda disabled auto-merge March 25, 2021 19:44
@Borda Borda merged commit 26eae39 into master Mar 25, 2021
@Borda Borda deleted the ci/add-pt-versions branch March 25, 2021 19:44
@Borda Borda added this to the 0.3 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing agains each feat PT version
3 participants