Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to provide distributed_available_fn #1301

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

justusschock
Copy link
Member

What does this PR do?

Fixes #1183

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@justusschock justusschock self-assigned this Oct 31, 2022
@justusschock justusschock added the distributed DDP, etc. label Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1301 (1fabd66) into master (a42a25a) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1301   +/-   ##
======================================
  Coverage      86%     87%           
======================================
  Files         190     190           
  Lines       11118   11121    +3     
======================================
+ Hits         9617    9620    +3     
  Misses       1501    1501           

@justusschock justusschock enabled auto-merge (squash) October 31, 2022 12:25
@mergify mergify bot added the ready label Oct 31, 2022
@justusschock justusschock merged commit 5bbad47 into master Oct 31, 2022
@justusschock justusschock deleted the fix_dist_sync_fn branch October 31, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dist_sync_fn seems dysfunctional
3 participants