Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precision issue in pairwise euclidean distance #1352

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 22, 2022

What does this PR do?

Fixes #1351

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Nov 22, 2022
@SkafteNicki SkafteNicki added this to the v0.11 milestone Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1352 (0e08bfa) into master (7d77daf) will decrease coverage by 56%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1352     +/-   ##
========================================
- Coverage      87%     30%    -56%     
========================================
  Files         210     210             
  Lines       11825   11807     -18     
========================================
- Hits        10249    3583   -6666     
- Misses       1576    8224   +6648     

@Borda Borda enabled auto-merge (squash) November 22, 2022 11:32
@mergify mergify bot added the ready label Nov 22, 2022
@Borda Borda merged commit d66cbc3 into master Nov 22, 2022
@Borda Borda deleted the bugfix/pairwise_precision branch November 22, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in pairwise_euclidean_distance
3 participants