Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Add support for py3.11 #1613

Merged
merged 78 commits into from
Apr 11, 2023
Merged

python: Add support for py3.11 #1613

merged 78 commits into from
Apr 11, 2023

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Mar 13, 2023 •
edited by Borda
Loading

What does this PR do?

extend compatibility

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@stancld stancld changed the title python: Add python 3.11 to CI python: Add support for python 3.11 Mar 13, 2023
@stancld stancld added test / CI testing or CI enhancement New feature or request labels Mar 13, 2023
Borda
Borda approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some time ago I tried but not all packages which we used as references were compatible, but maybe fine to skip them...

@stancld stancld marked this pull request as ready for review March 13, 2023 23:24
@stancld
Copy link
Contributor Author

stancld commented Mar 13, 2023

Some time ago I tried but not all packages which we used as references were compatible, but maybe fine to skip them...

I'll try to run the whole CI to see how things look like now

@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited
Loading

Codecov Report

Merging #1613 (6672517) into master (e4df071) will decrease coverage by 43%.
The diff coverage is 100%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #1613     +/-   ##
========================================
- Coverage      89%     46%    -43%     
========================================
  Files         230     230             
  Lines       12860   12860             
========================================
- Hits        11410    5924   -5486     
- Misses       1450    6936   +5486

akihironitta
akihironitta approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CI is all green, LGTM! 🚀

@mergify mergify bot added the ready label Mar 14, 2023
@Borda
Copy link
Member

Borda commented Mar 14, 2023

@stancld there are some errors with PL integration for 3.11, so maybe we can skip it as PL is not tested for 3.11 on its own yet...

@Borda Borda enabled auto-merge (squash) March 14, 2023 08:14
@stancld
Copy link
Contributor Author

stancld commented Mar 14, 2023 •
edited
Loading

@Borda Unfortunately, torchvision does not support python 3.11 yet. And neither next planned 0.15 release (which should be out today or tmrw I think) wouldn't introduce the support :[

@stancld
Copy link
Contributor Author

stancld commented Mar 14, 2023

@Borda We use only a few functions in our source code from torchvision for MeanAP. Do you think it's permissive to use our own implementations here to drop torchvision dependency in our source code and leave the package only for testing?

@Borda Borda disabled auto-merge April 3, 2023 15:57
@Borda Borda changed the title python: Add support for python 3.11 python: Add support for python 3.11 Apr 3, 2023
@Borda Borda changed the title python: Add support for python 3.11 python: Add support for py3.11 Apr 3, 2023
@Borda Borda enabled auto-merge (squash) April 3, 2023 15:59
@Borda
Copy link
Member

Borda commented Apr 3, 2023

tracking numba progress in numba/numba#8841 (comment)

@mergify mergify bot added the ready label Apr 3, 2023
@mergify mergify bot removed the ready label Apr 3, 2023
mergify bot and others added 7 commits April 4, 2023 06:21
@mergify
Merge branch 'master' into feature/python3.11
cc94562
@mergify
Merge branch 'master' into feature/python3.11
721d40a
@mergify
Merge branch 'master' into feature/python3.11
750894c
@mergify
Merge branch 'master' into feature/python3.11
da4271f
@mergify
Merge branch 'master' into feature/python3.11
402e311
@pre-commit-ci @Borda
[pre-commit.ci] pre-commit suggestions (#1688)Co-authored-by: pre-com…
2d25943 
…mit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* [pre-commit.ci] pre-commit suggestions

updates:
- [github.com/psf/black: 23.1.0 → 23.3.0](psf/black@23.1.0...23.3.0)
- [github.com/charliermarsh/ruff-pre-commit: v0.0.255 → v0.0.260](astral-sh/ruff-pre-commit@v0.0.255...v0.0.260)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* S301

* S310

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@mergify
Merge branch 'master' into feature/python3.11
09d7f30
@stancld
Copy link
Contributor Author

stancld commented Apr 5, 2023

tracking numba progress in numba/numba#8841 (comment)

Looks soon to be good! numba/numba#8841 (comment)

@stancld
Copy link
Contributor Author

stancld commented Apr 8, 2023

Gonna have a look at those failing tests.

@mergify mergify bot added the ready label Apr 8, 2023
@Borda Borda merged commit ee0e0d6 into master Apr 11, 2023
@Borda Borda deleted the feature/python3.11 branch April 11, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@akihironitta akihironitta akihironitta approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready test / CI testing or CI
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@stancld @Borda @SkafteNicki @justusschock @akihironitta