Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update pytorch-lightning requirement from <2.0.0,>=1.5 to >=1.5,<3.0.0 in /requirements #1636

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 21, 2023

Updates the requirements on pytorch-lightning to permit the latest version.

Release notes

Sourced from pytorch-lightning's releases.

Lightning 2.0: Fast, Flexible, Stable

Lightning AI is excited to announce the release of Lightning 2.0 ⚡

Over the last couple of years PyTorch Lightning has become the preferred deep learning framework for researchers and ML developers around the world, with close to 50 million downloads and 18k OSS projects, from top universities to leading labs.

With the help of over 800 contributors, we have added many features and functionalities to make it the most complete research toolkit possible, but some of these changes also introduced issues:

  • API changes to the trainer
  • Trainer code became harder to follow
  • Many integrations made Lightning appear bloated
  • The trainer became harder to customize / takes away what I instead need to tweak / have control over.

To make the research experience better, we are introducing 2.0:

  • No API changes - We commit to backward compatibility in the 2.0 series
  • Simplified abstraction layers, removed legacy functionality, integrations out of the main repo. This improves the project's readability and debugging experience.
  • Introducing Fabric. Scale any PyTorch model with just a few lines of code. Read-on!

Highlights

PyTorch 2.0 and torch.compile

Lightning 2.0 is best friends with PyTorch 2.0. You can torch.compile your LightningModules now!

import torch
import lightning as L
model = LitModel()
This will compile forward and {training,validation,test,predict}_step
compiled_model = torch.compile(model)
trainer = L.Trainer()
trainer.fit(compiled_model)

PyTorch reports that on average, "models runs 43% faster in training on an NVIDIA A100 GPU. At Float32 precision, it runs 21% faster on average and at AMP Precision it runs 51% faster on average" (source). If you want to learn more about torch.compile and how such speedups can be achieved, read the official PyTorch 2.0 blog post.

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the test / CI testing or CI label Mar 21, 2023
@dependabot dependabot bot requested a review from a team March 21, 2023 00:02
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1636 (e239f8b) into master (f2b85bb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1636   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         236     236           
  Lines       13230   13230           
======================================
  Hits        11648   11648           
  Misses       1582    1582           

@dependabot dependabot bot force-pushed the dependabot-pip-requirements-pytorch-lightning-gte-1.5-and-lt-3.0.0 branch from 5532f7b to 3fad714 Compare March 21, 2023 07:09
@Borda
Copy link
Member

Borda commented Mar 21, 2023

pending on #1633 (comment)

Updates the requirements on [pytorch-lightning](https://github.com/Lightning-AI/lightning) to permit the latest version.
- [Release notes](https://github.com/Lightning-AI/lightning/releases)
- [Commits](Lightning-AI/pytorch-lightning@1.5.0...2.0.0)

---
updated-dependencies:
- dependency-name: pytorch-lightning
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-pytorch-lightning-gte-1.5-and-lt-3.0.0 branch from 3fad714 to 1a91f14 Compare March 21, 2023 08:22
@SkafteNicki SkafteNicki mentioned this pull request Mar 21, 2023
4 tasks
@Borda Borda enabled auto-merge (squash) March 21, 2023 14:07
@Borda Borda added the Priority Critical task/issue label Mar 21, 2023
@Borda
Copy link
Member

Borda commented Mar 21, 2023

some devices mishmash for running tests with lighting 2.0, could you pls check @SkafteNicki

RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:1 and CPU!

@mergify mergify bot added the ready label Mar 21, 2023
@mergify mergify bot added ready and removed ready labels Apr 5, 2023
@mergify mergify bot added the has conflicts label Apr 5, 2023
@mergify mergify bot removed the ready label Apr 11, 2023
@mergify mergify bot added the ready label Apr 11, 2023
@mergify mergify bot removed the ready label Apr 11, 2023
@mergify mergify bot added the ready label Apr 12, 2023
@Borda Borda disabled auto-merge April 13, 2023 14:52
@Borda Borda merged commit d0a8452 into master Apr 13, 2023
@Borda Borda deleted the dependabot-pip-requirements-pytorch-lightning-gte-1.5-and-lt-3.0.0 branch April 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Critical task/issue ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants