Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding removal for 3d input in MSSSIM #1674

Merged
merged 8 commits into from
Apr 4, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1656

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 31, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 31, 2023
@mergify mergify bot requested a review from a team March 31, 2023 15:22
@Borda Borda enabled auto-merge (squash) March 31, 2023 15:42
@mergify mergify bot added the ready label Mar 31, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1674 (f3f0b0c) into master (9d3a7cc) will decrease coverage by 47%.
The diff coverage is 100%.

❗ Current head f3f0b0c differs from pull request most recent head 099567c. Consider uploading reports for the commit 099567c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1674     +/-   ##
========================================
- Coverage      89%     42%    -47%     
========================================
  Files         228     228             
  Lines       12796   12798      +2     
========================================
- Hits        11363    5365   -5998     
- Misses       1433    7433   +6000     

@Borda Borda disabled auto-merge April 4, 2023 23:07
@Borda Borda merged commit eb5cf63 into master Apr 4, 2023
@Borda Borda deleted the bugfix/ms_ssim_pad branch April 4, 2023 23:07
@SkafteNicki SkafteNicki mentioned this pull request Apr 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS-SSIM for 3D input
3 participants