Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kwarg squeeze in MultiOutputWrapper #1675

Merged
merged 8 commits into from
Apr 4, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1672

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 31, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 31, 2023
@Borda Borda enabled auto-merge (squash) March 31, 2023 15:41
@mergify mergify bot requested a review from a team March 31, 2023 15:42
@mergify mergify bot added the ready label Mar 31, 2023
@mergify mergify bot removed the ready label Mar 31, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1675 (0b6f2ea) into master (9d3a7cc) will decrease coverage by 48%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1675     +/-   ##
========================================
- Coverage      89%     40%    -48%     
========================================
  Files         228     228             
  Lines       12796   12795      -1     
========================================
- Hits        11363    5161   -6202     
- Misses       1433    7634   +6201     

@mergify mergify bot added the ready label Apr 3, 2023
@mergify mergify bot added the has conflicts label Apr 4, 2023
@Borda Borda disabled auto-merge April 4, 2023 23:08
@Borda Borda merged commit 714a8ca into master Apr 4, 2023
@Borda Borda deleted the bugfix/squeeze_kwargs_multioutput branch April 4, 2023 23:08
@mergify mergify bot removed the ready label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working has conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultioutputWrapper does not squeeze kwargs
3 participants