Fix the dice metric. Incorrect anotation #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeaMerci
requested review from
SkafteNicki,
Borda and
justusschock
as code owners
Borda
approved these changes
Apr 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1684 +/- ##
========================================
- Coverage 89% 52% -37%
========================================
Files 228 228
Lines 12794 12796 +2
========================================
- Hits 11355 6593 -4762
- Misses 1439 6203 +4764 |
justusschock
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the annotation of the Dice class, the average argument had the annotation literal["micro", "macro", "weighted", "sample"]. The anotation was incorrect and I removed the extra "weighted" element, which is missing from the list when checking the average argument. The anotation was misleading.