Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imports: deprecate from pkg root [1/n] Audio #1685

Merged
merged 24 commits into from
Apr 5, 2023
Merged

imports: deprecate from pkg root [1/n] Audio #1685

merged 24 commits into from
Apr 5, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 3, 2023 •
edited
Loading

What does this PR do?

Part of #1681 (comment)

  • class version
  • functional
  • tests
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda changed the title imports: deprecate Audio imports: deprecate Audio from pkg root Apr 3, 2023
@Borda Borda marked this pull request as ready for review April 3, 2023 22:55
@Borda Borda changed the title imports: deprecate Audio from pkg root imports: deprecate Audio from pkg root [1/n] Apr 3, 2023
@Borda Borda changed the title imports: deprecate Audio from pkg root [1/n] imports: deprecate from pkg root [1/n] Audio Apr 3, 2023
@Borda Borda requested a review from lantiga April 3, 2023 22:57
@Borda Borda added the refactoring refactoring and code health label Apr 3, 2023
@Borda Borda added this to the v1.0.0 milestone Apr 3, 2023
@Borda Borda requested a review from a team April 4, 2023 11:44
@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #1685 (60b6afe) into master (dd1df84) will decrease coverage by 0%.
The diff coverage is 72%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1685   +/-   ##
======================================
- Coverage      89%     89%   -0%     
======================================
  Files         228     230    +2     
  Lines       12796   12860   +64     
======================================
+ Hits        11363   11410   +47     
- Misses       1433    1450   +17

lantiga
lantiga requested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clarify the message and we're good to go.

src/torchmetrics/functional/audio/_deprecated.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from lantiga April 4, 2023 12:28
lantiga
lantiga reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved wording in comments.

src/torchmetrics/audio/_deprecated.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/audio/_deprecated.py Outdated Show resolved Hide resolved
Borda and others added 2 commits April 4, 2023 15:24
@Borda @lantiga
Apply suggestions from code review
023235f 
Co-authored-by: Luca Antiga <luca@lightning.ai>
@Borda
warnings
78534f0
@Borda Borda requested a review from lantiga April 4, 2023 13:37
@Borda Borda enabled auto-merge (squash) April 4, 2023 17:15
@mergify mergify bot added the ready label Apr 5, 2023
@Borda Borda disabled auto-merge April 5, 2023 11:51
@Borda Borda merged commit 6f2adc6 into master Apr 5, 2023
@Borda Borda deleted the imports/audio branch April 5, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@justusschock justusschock justusschock approved these changes

@stancld stancld stancld approved these changes

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki is a code owner

Assignees
No one assigned
Labels
ready refactoring refactoring and code health
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Borda @lantiga @justusschock @stancld