Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: lower audio test size #1718

Merged
merged 5 commits into from
Apr 17, 2023
Merged

CI: lower audio test size #1718

merged 5 commits into from
Apr 17, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

SDR / SNR test times are often among the highest and sometimes (too often) above the timeout threshold.
Try with smaller input to lower computations.

Example:
https://dev.azure.com/Lightning-AI/Metrics/_build/results?buildId=150556&view=logs&j=b817243f-a6e0-5fef-3435-47908ec3a6b7&t=172d1999-bd63-576d-9fa3-c0fe8e5a5e24

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the test / CI testing or CI label Apr 17, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1718 (0bedfdc) into master (f17afcb) will decrease coverage by 50%.
The diff coverage is 20%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1718     +/-   ##
========================================
- Coverage      88%     38%    -50%     
========================================
  Files         238     238             
  Lines       13331   13360     +29     
========================================
- Hits        11722    5052   -6670     
- Misses       1609    8308   +6699     

tests/unittests/audio/test_sdr.py Show resolved Hide resolved
@mergify mergify bot requested a review from a team April 17, 2023 14:58
@Borda Borda enabled auto-merge (squash) April 17, 2023 15:22
.codecov.yml Show resolved Hide resolved
@Borda Borda added the Priority Critical task/issue label Apr 17, 2023
@Borda Borda merged commit 527afbe into master Apr 17, 2023
@Borda Borda deleted the ci/audio_tests branch April 17, 2023 17:21
@mergify mergify bot added the ready label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Critical task/issue ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants