Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed permutation_invariant_training to allow using a 'permutation-wise' metric function #1794

Merged
merged 15 commits into from
May 22, 2023

Conversation

quancs
Copy link
Member

@quancs quancs commented May 19, 2023

What does this PR do?

Changed permutation_invariant_training to allow using a 'permutation-wise' metric function

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1794.org.readthedocs.build/en/1794/

@quancs quancs marked this pull request as ready for review May 21, 2023 12:56
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #1794 (995fcee) into master (dfbdaa9) will decrease coverage by 50%.
The diff coverage is 97%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1794     +/-   ##
========================================
- Coverage      87%     38%    -50%     
========================================
  Files         254     254             
  Lines       14228   14246     +18     
========================================
- Hits        12433    5357   -7076     
- Misses       1795    8889   +7094     

@mergify mergify bot added the ready label May 21, 2023
@Borda Borda enabled auto-merge (squash) May 21, 2023 13:21
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool :]

@Borda Borda merged commit d1ef354 into Lightning-AI:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants